Skip to content

Conversation

sBouzols
Copy link
Contributor

chore(): Add npm script to run the app in dev mode, using a dedicated vite config file which declare library dependencies as locale with alias and env variables and disable lintOnStart

Must have to install prettier-plugin-glsl as dev dependency like in the powsybl-network-viewer project to make eslint work.

… vite config file which declare library dependencies as locale with alias and env variables and disable lintOnStart

Must have to install `prettier-plugin-glsl` as dev dependency like in the powsybl-network-viewer project to make eslint work.

Signed-off-by: sBouzols <[email protected]>
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, I'll give it a shot.


If you are a developer and you want to update / enhance components used from the gridsuite commons-ui library
click [here](https://github.com/gridsuite/commons-ui) and follow instructions.
This app uses @powsybl/network-viewer library which released in the npmjs packages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This app uses @powsybl/network-viewer library which released in the npmjs packages.
This app also uses [@powsybl/network-viewer](https://github.com/powsybl/powsybl-network-viewer) library which released on [npmjs](https://www.npmjs.com/package/@powsybl/network-viewer).

},
{
// .frag files are recognized as JavaScript files by default
files: ['*.frag'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
files: ['*.frag'],
files: ['*.frag', '*.vert'],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants